[7.5][Transform] prevent assignment if any node is older than 7.4 #48055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml/Transform) |
benwtrent
reviewed
Oct 15, 2019
| node.isDataNode() && node.getVersion().onOrAfter(params.getVersion()) | ||
| node.isDataNode() && | ||
| // see gh#48019 disable assignment if any node is using 7.2 or 7.3 | ||
| clusterState.getNodes().getMinNodeVersion().onOrAfter(Version.V_7_4_0) && |
There was a problem hiding this comment.
I think this condition should be outside of the selectLeastLoadedNode function.
It is also good to return a new custom assignment explaining why we are not assigning to a node (e.g. Not assigning persistent task as cluster contains nodes with version older than 7.4.0).
benwtrent
approved these changes
Oct 15, 2019
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Oct 16, 2019
disable task assignment of transforms if any node uses version 7.2 or 7.3 (mixed cluster). fixes elastic#48019
hendrikmuhs
pushed a commit
that referenced
this pull request
Oct 17, 2019
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable task assignment of transforms if any node uses version 7.2 or 7.2 (mixed cluster).
fixes #48019
Note: not needed for master as the upgrade path is 7.last -> master