Fix testHistoryRetention #46799
Merged
Fix testHistoryRetention #46799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable backgorund sync to ensure that the replica's retention lease isn't expired (in a slow run that runs into the 30s default background sync interval) before recovery and we get ops based recovery. Closes elastic#45953
original-brownbear
added
>test
|
Pinging @elastic/es-distributed |
DaveCTurner
requested changes
Sep 18, 2019
There was a problem hiding this comment.
Good catch @original-brownbear, but I have a different idea for the fix. This test should work even if a retention lease sync happens. I think it would be better to suppress the reasonable-history check by setting index.recovery.file_based_threshold: 1.0. We're already using the InternalSettingsPlugin so it's just a case of using a different setting (see below).
server/src/test/java/org/elasticsearch/indices/recovery/IndexRecoveryIT.java
Outdated
Show resolved
Hide resolved
…ecoveryIT.java Co-Authored-By: David Turner <[email protected]>
|
Thanks @DaveCTurner makes sense => applied your fix :) |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Sep 18, 2019
Suppress the reasonable-history check in this test to guarantee we're always getting ops based recovery even after a background sync. Closes elastic#45953 Co-Authored-By: David Turner <[email protected]>
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Sep 18, 2019
Suppress the reasonable-history check in this test to guarantee we're always getting ops based recovery even after a background sync. Closes elastic#45953 Co-Authored-By: David Turner <[email protected]>
original-brownbear
added a commit
that referenced
this pull request
Sep 18, 2019
Suppress the reasonable-history check in this test to guarantee we're always getting ops based recovery even after a background sync. Closes #45953 Co-Authored-By: David Turner <[email protected]>
original-brownbear
added a commit
that referenced
this pull request
Sep 18, 2019
Suppress the reasonable-history check in this test to guarantee we're always getting ops based recovery even after a background sync. Closes #45953 Co-Authored-By: David Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable backgorund sync to ensure that the replica's retention lease
isn't expired (in a slow run that runs into the 30s default background
sync interval) before recovery and we get ops based recovery as
expected.
Closes #45953
Note: See my reproducer for the original failure here #45953 (comment)
Relates #45208 which added the logic that is expiring the retention leases here