Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Reformat rank feature query #44975

Merged
merged 8 commits into from
Jul 31, 2019
Merged

[DOCS] Reformat rank feature query #44975

merged 8 commits into from
Jul 31, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Jul 29, 2019 •
edited
Loading

Updates the rank_feature query to use the new query format.

This creates separate sections for the example requests, parameters, and notes.

This is part of #40977, an effort to standardize documentation for query types.

Preview

http://elasticsearch_44975.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/query-dsl-rank-feature-query.html

http://elasticsearch_44975.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/query-filter-context.html

@jrodewig jrodewig added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.0.2 v7.1.1 v7.4.0 v7.3.1 v7.2.2 labels Jul 29, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@jrodewig jrodewig mentioned this pull request Jul 29, 2019
Closed
62 tasks
jtibshirani
jtibshirani reviewed Jul 29, 2019
View reviewed changes
Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is really nice to see the new format! I left some minor comments.

@jrodewig jrodewig requested a review from jtibshirani July 30, 2019 13:15
@jrodewig jrodewig merged commit d9b2d8d into master Jul 31, 2019
@jrodewig jrodewig deleted the rank-feature-query branch July 31, 2019 18:31
jrodewig added a commit that referenced this pull request Jul 31, 2019
@jrodewig
[DOCS] Reformat rank feature query. Add relevance score section. (#44975
3c4150c 
)
jrodewig added a commit that referenced this pull request Jul 31, 2019
@jrodewig
[DOCS] Reformat rank feature query. Add relevance score section. (#44975
6c61907 
)
jrodewig added a commit that referenced this pull request Jul 31, 2019
@jrodewig
[DOCS] Reformat rank feature query. Add relevance score section. (#44975
7ad36c9 
)
jrodewig added a commit that referenced this pull request Jul 31, 2019
@jrodewig
[DOCS] Reformat rank feature query. Add relevance score section. (#44975
113e36c 
)
jrodewig added a commit that referenced this pull request Jul 31, 2019
@jrodewig
[DOCS] Reformat rank feature query. Add relevance score section. (#44975
17d0d25 
)
@jrodewig jrodewig mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtibshirani jtibshirani jtibshirani approved these changes

Assignees
No one assigned
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.0.2 v7.1.1 v7.2.2 v7.3.1 v7.4.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrodewig @elasticmachine @jtibshirani @jakelandis