-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Rewrite terms_set
query
#43060
Conversation
Pinging @elastic/es-search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @jrodewig, I didn't know this query very well and it was a pleasure reading the rewrite. Left one suggestions regarding "boost" again, also I wasn't sure about real-life use cases for this type of query so I did a bit of digging when/why this was added and found #26915. There are two more or less intuitive examples where this pretty specialized query might be useful in #26915 (comment). I don't know how far you want to take details in these reference docs but maybe there is a way of including some of these thoughts succinctly? Just an idea, maybe that makes the docs to complicated so I leave it up to you.
|
||
An example that always limits the number of required terms to match to never | ||
become larger than the number of terms specified: | ||
`boost`:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like in a previous PR, maybe we could mention the "boost" parameter on all queries for completeness but link to a common paragraph for the detailed discussion.
Thanks for the review and praise @cbuescher. I've updated the example and included the listed use cases with a33ee6e. Thanks for pointing out #26915. I feel like the examples are much more practical now. I also removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM
Changes
terms_set
queryThis is part of #40977, an effort to standardize documentation for query types.
Before
Before image
After
After image