Remove Delete Method from BlobStore #41619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
original-brownbear
commented
Apr 27, 2019
•
original-brownbear
commented
- The delete method on the blob store was used almost nowhere and just duplicates the delete method on the blob containers
- The fact that it provided for some recursive delete logic (that did not behave the same way on all implementations) was not used and not properly tested either
- Had to adjust the verification cleanup method a little since that was the only user of this logic. Now it uses list and then delete to clean up the blobs it creates.
* The delete method on the blob store was used almost nowhere and just duplicates the delete method on the blob containers * The fact that it provided for some recursive delete logic (that did not behave the same way on all implementations) was not used and not properly tested either
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed |
original-brownbear
requested review from
ywelsch
and removed request for
ywelsch
|
Jenkins run elasticsearch-ci/docbldesx |
|
From the "related note" in #41368 (review) :) |
andrershov
approved these changes
May 9, 2019
server/src/main/java/org/elasticsearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
|
Jenkins run elasticsearch-ci/docbldesx |
|
thanks @andrershov ! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 27, 2019
* Remove Delete Method from BlobStore * The delete method on the blob store was used almost nowhere and just duplicates the delete method on the blob containers * The fact that it provided for some recursive delete logic (that did not behave the same way on all implementations) was not used and not properly tested either
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* Remove Delete Method from BlobStore * The delete method on the blob store was used almost nowhere and just duplicates the delete method on the blob containers * The fact that it provided for some recursive delete logic (that did not behave the same way on all implementations) was not used and not properly tested either
original-brownbear
added a commit
that referenced
this pull request
May 27, 2019
* Remove Delete Method from BlobStore (#41619) * The delete method on the blob store was used almost nowhere and just duplicates the delete method on the blob containers * The fact that it provided for some recursive delete logic (that did not behave the same way on all implementations) was not used and not properly tested either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.