Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify initial_master_nodes must match node.name #41137

Conversation

DaveCTurner
Copy link
Contributor

... and emphasize that this includes any trailing qualifiers.

... and emphasize that this includes any trailing qualifiers.
@DaveCTurner DaveCTurner added >docs General docs changes :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v8.0.0 v7.2.0 v7.0.1 labels Apr 12, 2019
@DaveCTurner DaveCTurner requested a review from bleskes April 12, 2019 08:59
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@bleskes bleskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx David. I left some suggestions.

Copy link
Contributor Author

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bleskes, suggestions actioned.

@DaveCTurner DaveCTurner requested a review from bleskes April 12, 2019 09:24
Copy link
Contributor

@bleskes bleskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit cae6276 into elastic:master Apr 12, 2019
@DaveCTurner DaveCTurner deleted the 2019-04-12-bootstrap-docs-clarify-domainname branch April 12, 2019 09:45
DaveCTurner added a commit that referenced this pull request Apr 12, 2019
... and emphasize that this includes any trailing qualifiers.
DaveCTurner added a commit that referenced this pull request Apr 12, 2019
... and emphasize that this includes any trailing qualifiers.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 14, 2019
The following phrase causes confusion:

> Alternatively the IP addresses or hostnames (if node name defaults to the
> host name) can be used.

This change clarifies the conditions under which you can use a hostname, and
adds an anchor to the note introduced in (elastic#41137) so we can link directly to it
in conversations with users.
DaveCTurner added a commit that referenced this pull request Apr 14, 2019
The following phrase causes confusion:

> Alternatively the IP addresses or hostnames (if node name defaults to the
> host name) can be used.

This change clarifies the conditions under which you can use a hostname, and
adds an anchor to the note introduced in (#41137) so we can link directly to it
in conversations with users.
DaveCTurner added a commit that referenced this pull request Apr 14, 2019
The following phrase causes confusion:

> Alternatively the IP addresses or hostnames (if node name defaults to the
> host name) can be used.

This change clarifies the conditions under which you can use a hostname, and
adds an anchor to the note introduced in (#41137) so we can link directly to it
in conversations with users.
DaveCTurner added a commit that referenced this pull request Apr 14, 2019
The following phrase causes confusion:

> Alternatively the IP addresses or hostnames (if node name defaults to the
> host name) can be used.

This change clarifies the conditions under which you can use a hostname, and
adds an anchor to the note introduced in (#41137) so we can link directly to it
in conversations with users.
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
... and emphasize that this includes any trailing qualifiers.
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
The following phrase causes confusion:

> Alternatively the IP addresses or hostnames (if node name defaults to the
> host name) can be used.

This change clarifies the conditions under which you can use a hostname, and
adds an anchor to the note introduced in (elastic#41137) so we can link directly to it
in conversations with users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >docs General docs changes v7.0.1 v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants