Adjust testGetSslCertificates to run in FIPS #40046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discovered in elastic#40041, when parsing certificates from files, the SUN Security Provider normalizes DNs from parsed certificates by adding spaces between RDNs, while the BouncyCastle one (which we use in FIPS tests) does not. We could proceed to normalize the DNs in the same manner in this test by using i.e. the Unbound LDAP SDK but since the goal of this test is to validate that we do get to read these exact certificates from our trust sources and not to validate subject DNs, this commit changes the test to check the serial number instead Resolves: elastic#40041
jkakavas
added
>test
|
Pinging @elastic/es-security |
jkakavas
added a commit
that referenced
this pull request
Mar 14, 2019
As discovered in #40041, when parsing certificates from files, the SUN Security Provider normalizes DNs from parsed certificates by adding spaces between RDNs, while the BouncyCastle one (which we use in FIPS tests) does not. We could proceed to normalize the DNs in the same manner in this test by using i.e. the Unbound LDAP SDK but since the goal of this test is to validate that we do get to read these exact certificates from our trust sources and not to validate subject DNs, this commit changes the test to check the serial number instead Resolves: #40041
jkakavas
added a commit
that referenced
this pull request
Mar 14, 2019
As discovered in #40041, when parsing certificates from files, the SUN Security Provider normalizes DNs from parsed certificates by adding spaces between RDNs, while the BouncyCastle one (which we use in FIPS tests) does not. We could proceed to normalize the DNs in the same manner in this test by using i.e. the Unbound LDAP SDK but since the goal of this test is to validate that we do get to read these exact certificates from our trust sources and not to validate subject DNs, this commit changes the test to check the serial number instead Resolves: #40041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in #40041, when parsing certificates from files, the
SUN Security Provider normalizes DNs from parsed certificates by
adding spaces between RDNs, while the BouncyCastle one (which we
use in FIPS tests) does not.
We could proceed to normalize the DNs in the same manner in this
test by using i.e. the Unbound LDAP SDK but since the goal of this
test is to validate that we do get to read these exact certificates
from our trust sources and not to validate subject DNs, this commit
changes the test to check the serial number instead
Resolves: #40041