Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: fix COUNT DISTINCT column name #39537

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Feb 28, 2019

This PR removes the need for a custom named column in case of a DISTINCT COUNT function.

Fixes #39511.

@astefan astefan requested review from costin and matriv February 28, 2019 21:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please add the versioning as well (likely 6.x+)

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astefan astefan merged commit 9412a2e into elastic:master Mar 1, 2019
@astefan astefan deleted the 39511_fix branch March 1, 2019 13:23
astefan added a commit that referenced this pull request Mar 1, 2019
astefan added a commit that referenced this pull request Mar 1, 2019
astefan added a commit that referenced this pull request Mar 1, 2019
@astefan astefan removed the v6.6.2 label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL: COUNT(DISTINCT) column name has an extra DISTINCT in it
5 participants