Added missing builder.endObject calls

[spinscale]

After closing #3878 it came to me, that we might have other code snippets of missing or too much builder.endObject() / builder.startObject() methods (same for arrays), so I wrote this kind of hacky shell script

#/bin/bash
for x in Object Array ; do

    start="\.start$x"
    end="\.end$x"

    for i in $(ag -l "$start") ; do
        startingCount=$(grep -c "$start" $i)
        endingCount=$(grep -c "$end" $i)

        if [ $startingCount -ne $endingCount ] ; then
            echo "$i $x: start $startingCount end $endingCount"
        fi
    done

done

only found two other pieces of code and a couple of false positives.

I am thinking if we could automate this by doing something similar as the forbidden-api maven module does and parse the source itself (to prevent false positives).

Anyone having experience with that?

[dadoonet]

Nice script! I like it and the forbidden-api like thing.

[s1monw]

+1 to commit. Yet, I opened #3889 to move all this serialisation to the corresponding classes - once we are on that we should also add tests for this.