Fix synchronization in LocalCheckpointTracker#contains #38755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>bug
v7.0.0
:Distributed Indexing/Distributed
|
Pinging @elastic/es-distributed |
ywelsch
approved these changes
Feb 12, 2019
|
Thanks @ywelsch |
dnhatn
added a commit
that referenced
this pull request
Feb 12, 2019
We are accessing the `CountedBitSet` in `LocalCheckpointTracker#contains` without proper synchronization. Relates #33871
dnhatn
added a commit
that referenced
this pull request
Feb 12, 2019
We are accessing the `CountedBitSet` in `LocalCheckpointTracker#contains` without proper synchronization. Relates #33871
dnhatn
added a commit
that referenced
this pull request
Feb 12, 2019
We are accessing the `CountedBitSet` in `LocalCheckpointTracker#contains` without proper synchronization. Relates #33871
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 13, 2019
* master: Remove _type term filters from cluster alert watches (elastic#38819) Adjust log and unmute testFailOverOnFollower (elastic#38762) Fix line separators in JSON logging tests (elastic#38771) Fix synchronization in LocalCheckpointTracker#contains (elastic#38755) muted test Remove TLSv1.2 pinning in ssl reload tests (elastic#38651) Don't fail init script if `/proc/.../max_map_count` absent (elastic#35933) Format Watcher.status.lastChecked and lastMetCondition (elastic#38626) SQL: Implement `::` cast operator (elastic#38774) Ignore failing test
mfussenegger
added a commit
to crate/crate
that referenced
this pull request
Sep 30, 2019
See upstream changes: - elastic/elasticsearch#38755 - elastic/elasticsearch#34667
5 tasks
mfussenegger
added a commit
to crate/crate
that referenced
this pull request
Sep 30, 2019
See upstream changes: - elastic/elasticsearch#38755 - elastic/elasticsearch#34667
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Sep 30, 2019
See upstream changes: - elastic/elasticsearch#38755 - elastic/elasticsearch#34667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #38633, I realize that we are accessing a
CountedBitSetinLocalCheckpointTracker#containswithout proper synchronization.Relates #33871