Edits to text of Profile API documentation #38742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor edits (punctuation/usage/capitalization/etc.) of text.
For clarification, the only edits I made to the parameters list and collector reasons were to change the word "it's" to "its" (I thought it was difficult to tell from the edits preview what my changes were):
`score`::
This records the time taken to score a particular document via its Scorer
`global_aggregation`::
A collector that executes an aggregation against the global query scope, rather than the specified query. Because the global scope is necessarily different from the executed query, it must execute its own match_all query (which you will see added to the Query section) to collect your entire dataset
dmeiss
commented
Feb 11, 2019
| @@ -770,7 +770,7 @@ Which yields the following aggregation profile output | |||
|
|
|||
| From the profile structure we can see that the `my_scoped_agg` is internally being run as a `LongTermsAggregator` (because the field it is | |||
| aggregating, `likes`, is a numeric field). At the same level, we see a `GlobalAggregator` which comes from `my_global_agg`. That | |||
| aggregation then has a child `LongTermsAggregator` which from the second terms aggregation on `likes`. | |||
| aggregation then has a child `LongTermsAggregator` which comes from the second term's aggregation on `likes`. | |||
There was a problem hiding this comment.
I was a little unsure about the accuracy of this edit.
polyfractal
added
>docs
|
Pinging @elastic/es-search |
|
@elasticmachine test this please |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 13, 2019
* master: Improve CcrRepositoryIT mappings tests (elastic#38817) Unmute testClusterJoinDespiteOfPublishingIssues and testElectMasterWithLatestVersion (elastic#38555) ML allow aliased .ml-anomalies* index on PUT Job (elastic#38821) Filter out upgraded version index settings when starting index following (elastic#38838) Handle the fact that `ShardStats` instance may have no commit or seqno stats (elastic#38782) Edits to text of Profile API documentation (elastic#38742) muted test
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 13, 2019
* master: Improve CcrRepositoryIT mappings tests (elastic#38817) Unmute testClusterJoinDespiteOfPublishingIssues and testElectMasterWithLatestVersion (elastic#38555) ML allow aliased .ml-anomalies* index on PUT Job (elastic#38821) Filter out upgraded version index settings when starting index following (elastic#38838) Handle the fact that `ShardStats` instance may have no commit or seqno stats (elastic#38782) Edits to text of Profile API documentation (elastic#38742) muted test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor edits (punctuation/usage/capitalization/etc.) of text.