Ensure JavaDateMathParserTests are calling java formatters #37710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing JavaDateMathParserTests were using joda formatters instead of java ones and thus the tests were not running the expected code. This fixes the above and some follow up failures due to that. First some round up formatter issues are fixed, especially when using epoch dates, the parsing could be wrong and result in exceptions. Second, some dates cannot be handled the same in java8 like in joda time due to more strict parsing, when used in combination with epoch dates.
spinscale
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
|
@elasticmachine run elasticsearch-ci/1 |
|
@elasticmachine run elasticsearch-ci/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing JavaDateMathParserTests were using joda formatters instead
of java ones and thus the tests were not running the expected code.
This fixes the above and some follow up failures due to that.
First some round up formatter issues are fixed, especially when using
epoch dates, the parsing could be wrong and result in exceptions.
Second, some dates cannot be handled the same in java8 like in joda time
due to more strict parsing, when used in combination with epoch dates.