Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use executor SAME to handle search related handlers #37427

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Use executor SAME to handle search related handlers #37427

merged 1 commit into from
Jan 15, 2019

Conversation

hydrogen666
Copy link

@hydrogen666 hydrogen666 commented Jan 14, 2019

The executor was missed in the backport of #33732- Due to the internal forking to search or search_throttled threadpool there is no reason to fork to the search thread pool twice.

Closes #37392
Relates to #33732

@colings86 colings86 requested a review from s1monw January 15, 2019 09:35
@colings86 colings86 added >bug :Search/Search Search-related issues that do not fall into other categories labels Jan 15, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@s1monw s1monw removed the v7.0.0 label Jan 15, 2019
@s1monw s1monw changed the title use executor SAME to handle search related handlers Use executor SAME to handle search related handlers Jan 15, 2019
@s1monw
Copy link
Contributor

s1monw commented Jan 15, 2019

@elasticmachine ok to test

Copy link
Contributor

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1monw s1monw merged commit 8391103 into elastic:6.x Jan 15, 2019
@s1monw
Copy link
Contributor

s1monw commented Jan 15, 2019

@hydrogen666 thanks for fixing this! good catch!

s1monw pushed a commit that referenced this pull request Jan 15, 2019
The executor was missed in the backport of #33732- Due to the internal forking to search or search_throttled threadpool there is no reason to fork to the search thread pool twice.

Closes #37392
Relates to #33732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search/Search Search-related issues that do not fall into other categories v6.6.1 v6.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants