Avoid duplicate types deprecation messages in search-related APIs. #36802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>bug
:Search/Search
|
Pinging @elastic/es-search |
jtibshirani
force-pushed
the
search-deprecation-messages
branch
from
8c76d19 to
774ff0c
Compare
48 tasks
|
@jtibshirani Thanks Julie for following up on this PR. Is the goal to have only a single deprecation message when a user submits a query that references a type field inside the body? Do we want to have a single deprecation even if a type is also used in the url? Currently with your PR if we have a type both in the url, and inside the body, we still get 2 deprecation warnings:
|
|
Thanks @mayya-sharipova for taking a look. In your example, my goal was indeed to have two deprecation messages, because the user has specified a type in two distinct places. The situation I am trying to avoid is having two deprecation messages when there is only a type in the URL. |
mayya-sharipova
approved these changes
Dec 19, 2018
|
@elasticmachine run gradle build tests 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the check for using the
_typefield in queries out ofTypeFieldTypeand intoQueryShardContext#fieldMapper.Currently, we issue two separate deprecation messages when APIs like 'search', 'explain', and 'update by query' include types in the URL, because these APIs create a term filter on
_typeas part of their execution. Moving the deprecation check intoQueryShardContext#fieldMapperlets us avoid these duplicate messages.