Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecation info API: negative index.unassigned.node_left.delayed_timeout #36454

Merged
merged 4 commits into from
Dec 13, 2018
Merged

deprecation info API: negative index.unassigned.node_left.delayed_timeout #36454

merged 4 commits into from
Dec 13, 2018

Conversation

jakelandis
Copy link
Contributor

This commit adds support to check for negative values for index setting
index.unassigned.node_left.delayed_timeout for the deprecation info API.

relates #36024
relates #26828

@jakelandis
deprecation info API: negative index.unassigned.node_left.delayed_tim…
d9d8556 
…eout

This commit adds support to check for negative values for index setting
`index.unassigned.node_left.delayed_timeout` for the deprecation info API.

relates elastic#36024
relates elastic#26828
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@gwbrown gwbrown mentioned this pull request Dec 10, 2018
Closed
26 tasks
gwbrown
gwbrown requested changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one note about the details message, otherwise looks good. Thanks again!

DaveCTurner
DaveCTurner reviewed Dec 11, 2018
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of nits but structurally this looks good. CI seems to be all kinds of broken here. Perhaps it needs to be merged with a known-good recent commit from master?

@jakelandis
Copy link
Contributor Author

@gwbrown @DaveCTurner thanks for the reviews. changes implemented. Below is the final output.

"index_settings" : {
    "test" : [
      {
        "level" : "warning",
        "message" : "Negative values for index.unassigned.node_left.delayed_timeout are deprecated and should be set to 0",
        "url" : "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-7.0.html#_literal_index_unassigned_node_left_delayed_timeout_literal_may_no_longer_be_negative",
        "details" : "The index [test] has [index.unassigned.node_left.delayed_timeout] set to [-1m], but negative values are not allowed"
      }
    ]
  }

@jakelandis jakelandis mentioned this pull request Dec 11, 2018
Merged
DaveCTurner
DaveCTurner approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakelandis jakelandis merged commit 52fee63 into elastic:6.x Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwbrown gwbrown gwbrown approved these changes

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees
No one assigned
Labels
>deprecation v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakelandis @elasticmachine @gwbrown @DaveCTurner