SQL: Adds a set of geo objects for JDBC driver #36415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all math and WKB parser and refactors WKT parser
Switches to :libs:geo to present Geo classes on the JDBC client side.
imotov
added
>enhancement
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo |
|
Pinging @elastic/es-search |
imotov
force-pushed
the
add-geo-objects
branch
from
4005fe4 to
d7c51b3
Compare
|
retest this please |
|
I discussed this with @nknize and we decided that it might be better to split it into 2 PRs - one for libs:geo and another for sql portion. This should simplify the review process by reducing the size. I will open the first PR for geo portion shortly. |
|
I opened #36477 |
tomcallahan
removed
the
:Analytics/Geo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a set of objects to represent geo shapes in geo points on the client side.
Relates to #29872
Closes #35767