-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types removal - PUT and GET IndexTemplates. #35866
Conversation
Pinging @elastic/es-core-features |
e83c0f9
to
bd82842
Compare
jenkins test this |
637bc3e
to
f7d218b
Compare
I've refactored PutIndexTemplateRequest as part of this PR so that we can expose it safely in HLRC. Internally the This was the set of inconsistent approaches used:
Several of these methods call each other internally. I refactored them so that they all ultimately call |
f7d218b
to
1138f7b
Compare
jenkins test this |
For HLRC support PutIndexTemplateRequest now includes checks to change the toXContent format if it looks like custom doc types are used. Removed getTypedTemplate method that violated REST-api contract and added parameter to the GetIndexTemplatesRequest for the HLRC client to request typed templates Removed doc types from HLRC documentation examples PITR.toXContent() now strips type name from `mapping->_doc->properties` to make untyped REST requests with include_type_name=false Tidied PutIndexTemplateRequest inconsistencies - some public methods ran mappings through the `internalMappings` validation and some didn’t. All do now. Added new APIs to take mappings with no doc types embedded in mapping definition blobs which are apis we will document in HLRC. The legacy `source` and `mapping` apis that support type names in the blob are all marked as deprecated.
4a80bb8
to
a07accd
Compare
The outstanding work required here is that:
|
This overlaps with #37210 so not doing any more on this |
Add support for the
include_type_name
flag.For HLRC support PutIndexTemplateRequest now includes checks to change the toXContent format if it looks like custom doc types are used in mappings.