Add high-level REST client API for _freeze and _unfreeze
#35723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for `_freeze` and `_unfreeze` to the HLRC Relates to elastic#34352
javanna
reviewed
Nov 20, 2018
client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesRequestConverters.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/ShardAcknowledgedResponse.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/FreezeIndexRequest.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/ShardAcknowledgedResponse.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/ShardAcknowledgedResponse.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/UnfreezeIndexRequest.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/FreezeIndexRequest.java
Outdated
Show resolved
Hide resolved
| @@ -403,4 +403,20 @@ static Request analyze(AnalyzeRequest request) throws IOException { | |||
| req.setEntity(RequestConverters.createEntity(request, RequestConverters.REQUEST_BODY_CONTENT_TYPE)); | |||
| return req; | |||
| } | |||
|
|
|||
| static Request freezeIndex(FreezeIndexRequest freezeIndexRequest) { | |||
There was a problem hiding this comment.
just double checking that these should be added with all the other OSS API, I think it makes sense but let's be sure.
Does it make sense to add unit testing for these to IndicesRequestConvertersTests?
There was a problem hiding this comment.
everything is OSS in this package the serverside might not be
There was a problem hiding this comment.
I think that its fine that indices type things can be in the IndicesClient, regardless of their status of commercial/noncommercial.
|
@javanna I addressed your comments |
hub-cap
suggested changes
Nov 21, 2018
client/rest-high-level/src/main/java/org/elasticsearch/client/FreezeIndexRequest.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/FreezeIndexRequest.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesClient.java
Show resolved
Hide resolved
| @@ -403,4 +403,20 @@ static Request analyze(AnalyzeRequest request) throws IOException { | |||
| req.setEntity(RequestConverters.createEntity(request, RequestConverters.REQUEST_BODY_CONTENT_TYPE)); | |||
| return req; | |||
| } | |||
|
|
|||
| static Request freezeIndex(FreezeIndexRequest freezeIndexRequest) { | |||
There was a problem hiding this comment.
I think that its fine that indices type things can be in the IndicesClient, regardless of their status of commercial/noncommercial.
client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesClient.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/UnfreezeIndexRequest.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/core/AcknowledgedRequest.java
Outdated
Show resolved
Hide resolved
where are the docs missing? |
hub-cap
suggested changes
Nov 26, 2018
client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesClient.java
Outdated
Show resolved
Hide resolved
|
@hub-cap I pushed new commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for
_freezeand_unfreezeto the HLRCRelates to #34352