GEO: More robust handling of ignore_malformed in geoshape parsing #35603
Conversation
Adds a method to XContent parser to skip all children of a current element in case of the parsing failure and applies this method to be able to ignore the rest of the GeoJson shape if the parsing fails and we need to ignore the geoshape due to the ignore malformed flag. Supersedes elastic#34498 Closes elastic#34047
imotov
added
>bug
:Analytics/Geo
|
Pinging @elastic/es-search-aggs |
|
EDIT: wrong nik. sorry @nik9000 github suggested you, but if you think somebody else is in a better position to review the XContentParser portion, please feel free to reassign. |
|
I like the idea but at the same time I'd like to avoid adding more methods to XContentParser. I'm wondering whether we could do something similar with a wrapper instead that would count levels similarly to what you are doing in your Mark impl? |
|
@jpountz that sounds like a great idea! Let me try that. |
…obust-error-handling-in-geojson-parser-ii
| public XContentSubParser(XContentParser parser) { | ||
| this.parser = parser; | ||
| if (parser.currentToken() != Token.START_OBJECT) { | ||
| throw new IllegalStateException("The sub parser has to be created on the start of an object"); |
|
|
||
| @Override | ||
| public boolean isClosed() { | ||
| return parser.isClosed(); |
There was a problem hiding this comment.
I'm wondering whether the fact that this would still return false after close has been called could be confusing.
There was a problem hiding this comment.
Indeed! I missed this one. Good catch! I will fix that.
…5603) Adds an XContent sub parser class that can to wrap another XContent parser at the beginning of an object and allow skiping all children in case of the parsing failure. It also uses this subparser to ignore the rest of the GeoJson shape if the parsing fails and we need to ignore the geoshape due to the ignore_malformed flag. Supersedes #34498 Closes #34047
imotov
deleted the
issue-34047-more-robust-error-handling-in-geojson-parser-ii
branch
Adds a method to XContent parser to skip all children of a current
element in case of the parsing failure and applies this method to be
able to ignore the rest of the GeoJson shape if the parsing fails and
we need to ignore the geoshape due to the ignore malformed flag.
Supersedes #34498
Closes #34047