Fix put/resume follow request parsing #34913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds some fields that were missing from put follow, and fixes a bug in resume follow.
jasontedor
added
>non-issue
:Distributed Indexing/CCR
|
Pinging @elastic/es-distributed |
jasontedor
commented
Oct 26, 2018
| @@ -73,14 +73,16 @@ | |||
| PARSER.declareInt(ConstructingObjectParser.constructorArg(), MAX_READ_REQUEST_OPERATION_COUNT); | |||
| PARSER.declareField( | |||
| ConstructingObjectParser.constructorArg(), | |||
| (p, c) -> ByteSizeValue.parseBytesSizeValue(p.text(), MAX_READ_REQUEST_SIZE.getPreferredName()), MAX_READ_REQUEST_SIZE, | |||
| (p, c) -> ByteSizeValue.parseBytesSizeValue(p.text(), MAX_READ_REQUEST_SIZE.getPreferredName()), | |||
| MAX_READ_REQUEST_SIZE, | |||
There was a problem hiding this comment.
This is only a formatting change.
jasontedor
commented
Oct 26, 2018
| (p, c) -> ByteSizeValue.parseBytesSizeValue(p.text(), MAX_WRITE_BUFFER_SIZE.getPreferredName()), MAX_WRITE_REQUEST_SIZE, | ||
| ObjectParser.ValueType.STRING); | ||
| ConstructingObjectParser.constructorArg(), | ||
| (p, c) -> ByteSizeValue.parseBytesSizeValue(p.text(), MAX_WRITE_REQUEST_SIZE.getPreferredName()), |
There was a problem hiding this comment.
Note buffer -> request.
jasontedor
commented
Oct 26, 2018
| @@ -66,12 +68,18 @@ public Response newResponse() { | |||
| PARSER.declareString(Request::setLeaderIndex, LEADER_INDEX_FIELD); | |||
| PARSER.declareString((req, val) -> req.followRequest.setFollowerIndex(val), FOLLOWER_INDEX_FIELD); | |||
| PARSER.declareInt((req, val) -> req.followRequest.setMaxReadRequestOperationCount(val), MAX_READ_REQUEST_OPERATION_COUNT); | |||
| PARSER.declareInt((req, val) -> req.followRequest.setMaxOutstandingReadRequests(val), MAX_OUTSTANDING_READ_REQUESTS); | |||
There was a problem hiding this comment.
I put this field in the same order as in resume.
jasontedor
commented
Oct 26, 2018
| PARSER.declareField( | ||
| (req, val) -> req.followRequest.setMaxReadRequestSize(val), | ||
| (p, c) -> ByteSizeValue.parseBytesSizeValue(p.text(), MAX_READ_REQUEST_SIZE.getPreferredName()), | ||
| MAX_READ_REQUEST_SIZE, | ||
| ObjectParser.ValueType.STRING); | ||
| PARSER.declareInt((req, val) -> req.followRequest.setMaxOutstandingReadRequests(val), MAX_OUTSTANDING_READ_REQUESTS); | ||
| PARSER.declareInt((req, val) -> req.followRequest.setMaxWriteRequestOperationCount(val), MAX_WRITE_REQUEST_OPERATION_COUNT); |
There was a problem hiding this comment.
This field was missing.
jasontedor
commented
Oct 26, 2018
| PARSER.declareField( | ||
| (req, val) -> req.followRequest.setMaxReadRequestSize(val), | ||
| (p, c) -> ByteSizeValue.parseBytesSizeValue(p.text(), MAX_READ_REQUEST_SIZE.getPreferredName()), | ||
| MAX_READ_REQUEST_SIZE, | ||
| ObjectParser.ValueType.STRING); | ||
| PARSER.declareInt((req, val) -> req.followRequest.setMaxOutstandingReadRequests(val), MAX_OUTSTANDING_READ_REQUESTS); | ||
| PARSER.declareInt((req, val) -> req.followRequest.setMaxWriteRequestOperationCount(val), MAX_WRITE_REQUEST_OPERATION_COUNT); | ||
| PARSER.declareField( |
There was a problem hiding this comment.
This field was missing.
jasontedor
added a commit
that referenced
this pull request
Oct 26, 2018
This commit adds some fields that were missing from put follow, and fixes a bug in resume follow.
jasontedor
added a commit
that referenced
this pull request
Oct 26, 2018
This commit adds some fields that were missing from put follow, and fixes a bug in resume follow.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 26, 2018
* master: Fix put/resume follow request parsing (elastic#34913)
jasontedor
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Oct 26, 2018
* master: Introduce cross-cluster replication API docs (elastic#34726) Responses can use Writeable.Reader interface (elastic#34655) SQL: Provide null-safe scripts for Not and Neg (elastic#34877) Fix put/resume follow request parsing (elastic#34913) Fix line length for org.elasticsearch.common.* files (elastic#34888) [ML] Extract common native process base class (elastic#34856) Refactor children aggregator into a generic ParentJoinAggregator (elastic#34845) [Style] Fix line lengths in action.admin.indices (elastic#34890) HLRC - add support for source exists API (elastic#34519)
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This commit adds some fields that were missing from put follow, and fixes a bug in resume follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some fields that were missing from put follow, and fixes a bug in resume follow.