Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Punjabi to unsupported Kerberos locales list #34440

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Add Punjabi to unsupported Kerberos locales list #34440

merged 1 commit into from
Oct 16, 2018

Conversation

DaveCTurner
Copy link
Contributor

Relates #33253 and fixes another test failure similar to #33228.

@DaveCTurner
Add Punjabi to unsupported Kerberos locales list
0143ef1 
Relates elastic#33253 and fixes another test failure similar to elastic#33228.
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests v7.0.0 v6.5.0 v6.4.3 labels Oct 15, 2018
@DaveCTurner DaveCTurner requested a review from bizybot October 15, 2018 06:10
@DaveCTurner
Copy link
Contributor Author

The test failure in question reproduces at 72d818c with:

./gradlew :x-pack:qa:evil-tests:test \
  -Dtests.seed=3F155F22683C4D97 \
  -Dtests.class=org.elasticsearch.xpack.security.authc.kerberos.SimpleKdcLdapServerTests \
  -Dtests.method="testClientServiceMutualAuthentication" \
  -Dtests.security.manager=false \
  -Dtests.locale=pa-Arab-PK \
  -Dtests.timezone=Asia/Bishkek \
  -Dcompiler.java=11 \
  -Druntime.java=11

I'm not sure why this wasn't picked up in the search done for #33253 - perhaps JDK11 added more locales?

@colings86 colings86 added the :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) label Oct 15, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

bizybot
bizybot approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@bizybot bizybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this locale got added for JDK11, Thanks.

@DaveCTurner DaveCTurner merged commit 67e7464 into elastic:master Oct 16, 2018
@DaveCTurner DaveCTurner deleted the 2018-10-15-unsupported-kerberos-locale branch October 16, 2018 11:16
DaveCTurner added a commit that referenced this pull request Oct 16, 2018
@DaveCTurner
Add Punjabi to unsupported Kerberos locales list (#34440)
06027b9 
Relates #33253 and fixes another test failure similar to #33228.
kcm pushed a commit that referenced this pull request Oct 30, 2018
@DaveCTurner @kcm
Add Punjabi to unsupported Kerberos locales list (#34440)
4209dd5 
Relates #33253 and fixes another test failure similar to #33228.
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bizybot bizybot bizybot approved these changes

Assignees
No one assigned
Labels
:Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) >test Issues or PRs that are addressing/adding tests v6.4.3 v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DaveCTurner @elasticmachine @bizybot @colings86 @jimczi