Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X-Pack] Beats centralized management: security role + licensing #34305

Merged
merged 2 commits into from
Oct 10, 2018

Conversation

ycombinator
Copy link
Contributor

Backport of #30520 to 6.x. Original description:

Resolves #30493.

This PR adds:

  • a built-in role, beats_admin that provides unfettered access to the .management-beats index. The purpose of this index is to store configuration and other peripheral information to make the Beats Centralized Management feature work.
  • licensing-related logic for the Beats Centralized Management feature.

…stic#30520)

* Adding Beats x-pack plugin + index templates

* Adding built-in roles for Beats central management

* Fixing typo

* Refactoring: extract common code into method

* More refactoring for more code reuse

* Use a single index for Beats management

* Rename "fragment" to "block"

* Adding configuration block type

* Expand kibana_system role to include Beats management index privileges

* Fixing syntax

* Adding test

* Adding asserting for reserved role

* Fixing privileges

* Updating template

* Removing beats plugin

* Fixing tests

* Fixing role variable name

* Fixing assertions

* Switching to preferred syntax for boolean false checks

* Making class final

* Making variables final

* Updating Basic license message to be more accurate
@ycombinator ycombinator requested a review from jaymode October 4, 2018 13:46
@ycombinator ycombinator added review :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC labels Oct 4, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@elasticmachine
Copy link
Collaborator

Pinging @elastic/beats

@exekias
Copy link

exekias commented Oct 4, 2018

It seems there are some issues in the testing code, probably something changed?

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but someone from the ES team should also have a look.

Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator ycombinator merged commit 3ac2b31 into elastic:6.x Oct 10, 2018
@ycombinator ycombinator deleted the backport-30520 branch October 10, 2018 10:46
@mattapperson
Copy link

@ycombinator 🎉 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>feature :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC v6.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants