Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup assertions in global checkpoint listeners #33722

Merged

Conversation

jasontedor
Copy link
Member

This commit is a cleanup of the assertions in global checkpoint listeners, simplifying them and adding some messages to them in case the assertions trip.

Relates #33690

This commit is a cleanup of the assertions in global checkpoint
listeners, simplifying them and adding some messages to them in case the
assertions trip.
@jasontedor jasontedor added >non-issue v7.0.0 :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v6.5.0 labels Sep 14, 2018
@jasontedor jasontedor requested a review from dnhatn September 14, 2018 15:41
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for an extra iteration.

@jasontedor jasontedor merged commit a0f0d78 into elastic:master Sep 14, 2018
jasontedor added a commit that referenced this pull request Sep 14, 2018
This commit is a cleanup of the assertions in global checkpoint
listeners, simplifying them and adding some messages to them in case the
assertions trip.
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Sep 14, 2018
* master:
  Add script to cache dependencies (elastic#33726)
  [DOCS] Moves security reference to docs folder (elastic#33643)
  Cleanup assertions in global checkpoint listeners (elastic#33722)
  [CCR] Move ccr tests in core module back to ccr module (elastic#33711)
  HLRC: ML PUT Calendar (elastic#33362)
  [Tests] Fix randomization in StringTermsIT (elastic#33678)
  Pin TLS1.2 in SSLConfigurationReloaderTests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >non-issue v6.5.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants