Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge_ngram is now edgeNGram? #30653

Closed
wants to merge 1 commit into from
Closed

edge_ngram is now edgeNGram? #30653

wants to merge 1 commit into from

Conversation

ifo20
Copy link

@ifo20 ifo20 commented May 16, 2018

I had errors trying to PUT mapping with the syntax as per this documentation. From stackoverflow answers I saw different spelling and treatment of min/max as strings rather than ints. Is this update required?

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

I had errors trying to PUT mapping with the syntax as per this documentation. From stackoverflow answers I saw different spelling and treatment of min/max as strings rather than ints. Is this update required?
@jimczi
Copy link
Contributor

jimczi commented May 16, 2018

Both form ( edge_ngram and edgeNGram) should be accepted but we want to deprecate the camel case form because it is not consistent with the naming of the other filters:
#30209
I hope you don't mind if I close your pr, the documentation is correct and we have tests that check the execution of these snippets. If you have errors with this syntax I suggest that you open an issue first with a complete recreation.

@jimczi jimczi closed this May 16, 2018
@ifo20
Copy link
Author

ifo20 commented May 17, 2018

Ah my mistake. Thanks for the explanation - indeed I did manage to get it working with edge_ngram in the end so must have been some other bug I had

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants