Remove deprecated createParser methods #28697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the final instances of the callers of `XContent.createParser` and `XContentHelper.createParser` that did not pass in the `DeprecationHandler`. It also removes the now-unused deprecated methods and fully removes any mention of Log4j or LoggingDeprecationHandler from the XContent code. Relates to elastic#28504
imotov
approved these changes
Feb 15, 2018
| @Deprecated | ||
| default XContentParser createParser(NamedXContentRegistry xContentRegistry, Reader reader) throws IOException { | ||
| return createParser(xContentRegistry, LoggingDeprecationHandler.INSTANCE, reader); | ||
| } |
| @@ -316,7 +316,7 @@ public void writeRawField(String name, InputStream content, XContentType content | |||
| if (mayWriteRawData(contentType) == false) { | |||
| // EMPTY is safe here because we never call namedObject when writing raw data | |||
| try (XContentParser parser = XContentFactory.xContent(contentType) | |||
| .createParser(NamedXContentRegistry.EMPTY, LoggingDeprecationHandler.INSTANCE, content)) { | |||
| .createParser(NamedXContentRegistry.EMPTY, DeprecationHandler.THROW_UNSUPPORTED_OPERATION, content)) { | |||
There was a problem hiding this comment.
I think an explanation why it's ok to throw an exception here might be helpful for future us.
There was a problem hiding this comment.
Sure, I'll add a comment, good idea
dakrone
added a commit
that referenced
this pull request
Feb 16, 2018
* Remove deprecated createParser methods This removes the final instances of the callers of `XContent.createParser` and `XContentHelper.createParser` that did not pass in the `DeprecationHandler`. It also removes the now-unused deprecated methods and fully removes any mention of Log4j or LoggingDeprecationHandler from the XContent code. Relates to #28504 * Add comments in JsonXContentGenerator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the final instances of the callers of
XContent.createParserandXContentHelper.createParserthat did not pass in theDeprecationHandler. Italso removes the now-unused deprecated methods and fully removes any mention of
Log4j or LoggingDeprecationHandler from the XContent code.
Relates to #28504