Make the README use a single type in examples. #26098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently indexes both users and tweets as their own types. Closes elastic#25978
dadoonet
reviewed
Aug 8, 2017
README.textile
Outdated
| @@ -50,17 +49,19 @@ h3. Indexing | |||
| Let's try and index some twitter like information. First, let's create a twitter user, and add some tweets (the @twitter@ index will be created automatically): | |||
|
|
|||
| <pre> | |||
| curl -XPUT 'http://localhost:9200/twitter/user/kimchy?pretty' -H 'Content-Type: application/json' -d '{ "name" : "Shay Banon" }' | |||
| curl -XPUT 'http://localhost:9200/twitter/doc/user_kimchy?pretty' -H 'Content-Type: application/json' -d '{ "type": "user", "name" : "Shay Banon" }' | |||
There was a problem hiding this comment.
In real life, would we create instead 2 indices?
curl -XPUT 'http://localhost:9200/twitter_user/doc/kimchy'
curl -XPUT 'http://localhost:9200/twitter_tweet/doc/1'
|
I did not do that in order to keep changes minimal but I think you are right that we should use different indices for tweets and users, I'll fix. |
|
@dadoonet I ended up only having one index for tweets to keep things simple, can you have another look? |
dadoonet
reviewed
Aug 8, 2017
README.textile
Outdated
| @@ -125,29 +129,27 @@ h3. Multi Tenant - Indices and Types | |||
|
|
|||
| Man, that twitter index might get big (in this case, index size == valuation). Let's see if we can structure our twitter system a bit differently in order to support such large amounts of data. | |||
|
|
|||
| Elasticsearch supports multiple indices, as well as multiple types per index. In the previous example we used an index called @twitter@, with two types, @user@ and @tweet@. | |||
| Elasticsearch supports multiple indices, and each index may store heterogeneous documents. In the previous example we used an index called @twitter@ that stored both @user@s and @tweet@s. | |||
There was a problem hiding this comment.
Do we want to say that in this intro documentation?
There was a problem hiding this comment.
"that stored both" is wrong now.
| { | ||
| "user": "kimchy", | ||
| "post_date": "2009-11-15T14:12:12", | ||
| "message": "Another tweet, will it be indexed?" | ||
| }' | ||
| </pre> | ||
|
|
||
| The above will index information into the @kimchy@ index, with two types, @info@ and @tweet@. Each user will get their own special index. | ||
| The above will index information into the @kimchy@ index. Each user will get their own special index. |
There was a problem hiding this comment.
I don't believe this is true but I might be misreading though.
dadoonet
approved these changes
Aug 8, 2017
| { | ||
| "user": "kimchy", | ||
| "post_date": "2009-11-15T14:12:12", | ||
| "message": "Another tweet, will it be indexed?" | ||
| }' | ||
| </pre> | ||
|
|
||
| The above will index information into the @kimchy@ index, with two types, @info@ and @tweet@. Each user will get their own special index. | ||
| The above will index information into the @kimchy@ index. Each user will get their own special index. |
jpountz
added a commit
that referenced
this pull request
Aug 10, 2017
It currently indexes both users and tweets as their own types. Closes #25978
jpountz
added a commit
that referenced
this pull request
Aug 10, 2017
It currently indexes both users and tweets as their own types. Closes #25978
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Aug 14, 2017
* master: (30 commits) Rewrite range queries with open bounds to exists query (elastic#26160) Fix eclipse compilation problem (elastic#26170) Epoch millis and second formats parse float implicitly (Closes elastic#14641) (elastic#26119) fix SplitProcessor targetField test (elastic#26178) Fixed typo in README.textile (elastic#26168) Fix incorrect class name in deleteByQuery docs (elastic#26151) Move more token filters to analysis-common module reindex: automatically choose the number of slices (elastic#26030) Fix serialization of the `_all` field. (elastic#26143) percolator: Hint what clauses are important in a conjunction query based on fields Remove unused Netty-related settings (elastic#26161) Remove SimpleQueryStringIT#testPhraseQueryOnFieldWithNoPositions. Tests: reenable ShardReduceIT#testIpRange. Allow `ClusterState.Custom` to be created on initial cluster states (elastic#26144) Teach the build about betas and rcs (elastic#26066) Fix wrong header level inner hits: Unfiltered nested source should keep its full path Document how to import Lucene Snapshot libs when elasticsearch clients (elastic#26113) Use `global_ordinals_hash` execution mode when sorting by sub aggregations. (elastic#26014) Make the README use a single type in examples. (elastic#26098) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently indexes both users and tweets as their own types.
Closes #25978