Scripting: Move context definitions to instance type classes #24883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple refactoring to move the context definitions into the type that they use. While we have multiple context names for the same class at the moment, this will eventually become one ScriptContext per instance type, so the pattern of a static member on the interface called CONTEXT can be used. This commit also moves the consolidated list of contexts provided by core ES into ScriptModule.
rjernst
added
:Core/Infra/Scripting
jasontedor
added a commit
to mashudong/elasticsearch
that referenced
this pull request
May 28, 2017
* master: (38 commits) Fix Lucene version expectation Verify Lucene version constants Avoid double decrement on current query counter Remove the need for _UNRELEASED suffix in versions (elastic#24798) Adjust available and free bytes to be non-negative on huge FSes Begin replacing static index tests with full restart tests (elastic#24846) Fix plugin docs for using custom config dir Update context-suggest.asciidoc Move BWC version to 5.5 after backport Support Multiple Collapse Inner Hits Scripting: Rename CompiledType to FactoryType in ScriptContext (elastic#24897) Scripting: Make contexts available to ScriptEngine construction (elastic#24896) Mute index and relocate concurrently Build: Add back explicit exclusions and remove gradle exclusions (elastic#24879) Scripting: Move context definitions to instance type classes (elastic#24883) Build: Fix hadoop integ test error on windows (elastic#24885) Put mapping and index template requests do not need content type detection for 5.3.0+ (elastic#24835) Add the ability to store objects with a ScrollContext (elastic#24777) add docs example for Ingest scripts manipulating document metadata (elastic#24875) Fix error message if an incompatible node connects (elastic#24884) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple refactoring to move the context definitions into the
type that they use. While we have multiple context names for the same
class at the moment, this will eventually become one ScriptContext per
instance type, so the pattern of a static member on the interface called
CONTEXT can be used. This commit also moves the consolidated list of
contexts provided by core ES into ScriptModule.