Rework bwc snapshot projects to build up to two bwc versions #24870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `:distribution:bwc-stable` project which builds the previous stable branch when `:distribution:bwc` is building an unreleased branch. When `:distribution:bwc` builds a released branch then `:distribution:bwc-stable` is an empty build, not used or depended on by anything. Relates to elastic#24798
|
Let the naming debates begin! |
|
I think you have the names mixed up. We currently have master, which is the unstable branch, 5.x which is the stable branch, and 5.4 which is our current release branch. But with this change, bwc-stable will build 5.4 snapshot, correct? Can we have bwc-release and bwc-stable? If on stable branch, then versions[-1] should be linked to bwc-release. If on unstable branch, then versions[-1] linked to bwc-stable and versions[-2] to bwc-release. |
Now we have `bwc-release` and `bwc-stable`. `bwc-release` is used to build release branches - 5.4 in master, 5.5 eventually, etc. `bwc-stable` is used for building unstable branches - `5.x` in master, `6.x` eventually. These names line up with the way folks talk about the names of Lucene's branches. Those names make sense so we may as well use them for our own branches.
|
@rjernst I've reworked the names so they line up. |
rjernst
approved these changes
May 26, 2017
|
Sure. `-snapshot` is fine. Makes sense because we only need it for
snapshots.
…On Fri, May 26, 2017 at 1:26 PM Ryan Ernst ***@***.***> wrote:
***@***.**** approved this pull request.
Thank you, this looks good! I just have one more very minor request. Upon
further reflection, I think it would be good to suffix these projects with
-snapshot? So bwc-stable-snapshot and bwc-release-snapshot?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24870 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLot_EX_5B2-DVFPXsmORY5ZNQh818ks5r9ws3gaJpZM4Nljmc>
.
|
|
Ok - I've made the changes and will merge in a moment. I plan to just merge to master because we aren't super likely to need it in 5.x. At least I don't think we are.... |
nik9000
changed the title
:distribution:bwc-stable project
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 29, 2017
* master: Add a second refresh to concurrent relocation test Add a dummy_index to upgrade tests to ensure we recover fine with replicas (elastic#24937) Rework bwc snapshot projects to build up to two bwc versions (elastic#24870) Move the IndexDeletionPolicy to be engine internal (elastic#24930) [Tests] Harden InternalExtendedStatsTests (elastic#24934) TCorrecting api name (elastic#24924) Add search method to high level REST client (elastic#24796) Add fromXContent method to ClearScrollResponse (elastic#24909) ClearScrollRequest to implement ToXContentObject (elastic#24907) SearchScrollRequest to implement ToXContentObject (elastic#24906) Fix bug in weight computation for query cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
distribution:bwcproject in favor ofdistribution:bwc-release-snapshotanddistribution:bwc-stable-snapshot.distribution:bwc-release-snapshotbuilds a snapshot of thelatest release branch (5.4 now) if needed for backwards
compatibility.
distribution:bwc-stable-snapshotbuilds asnapshot of the latest stable branch (5.x now) if needed for
backwards compatibility.
I edited the description to match what was actually committed. This was the old description for posterity:
Adds the
:distribution:bwc-stableproject which builds the previousstable branch when
:distribution:bwcis building an unreleasedbranch. When
:distribution:bwcbuilds a released branch then:distribution:bwc-stableis an empty build, not used or dependedon by anything.
Requires #24798