Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably when we updated Azure SDK, we introduced a regression.
Actually, we are not able to remove files anymore.
For example, if you register a new azure repository, the snapshot service tries to create a temp file and then remove it.
Removing does not work and you can see in logs:
This fix deals with that. It now list all the files in a flatten mode, remove in the full URL the server and the container name.
As an example, when you are removing a blob which full name is
https://dpi24329.blob.core.windows.net/elasticsearch-snapshots/bar/test
you need to actually call Azure SDK withbar/test
as the path,elasticsearch-snapshots
is the container.Related to #16472.
Related to #18436.
Backport of #18451 in 2.x branch
To test it, I ran some manual tests:
On my laptop, create a file
/path/to/azure/config/elasticsearch.yml
:Run
AzureRepositoryF#main()
with-Des.cluster.routing.allocation.disk.threshold_enabled=false -Des.path.home=/path/to/azure/
options.Then run:
Then check files we have on azure platform using the console.
Then run:
curl -XDELETE localhost:9200/_snapshot/my_backup1/snap1?pretty
Then check files we have on azure platform using the console and verify that everything has been cleaned.