Add a soft limit on the number of shards that can be queried in a single search request. #17396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
>enhancement
review
:Search/Search
24 tasks
|
The goal was initially to not apply this limit to count requests, but it is not trivial to check and after some discussions with @clintongormley, this is not so much of an issue since the limit is easy to change and you can get counts of docs in indices using eg. |
|
@jpountz thanks for the explanation. |
…gle search request. elastic#17396 This commit adds the new `action.search.shard_count.limit` setting which configures the maximum number of shards that can be queried in a single search request. It has a default value of 1000.
jpountz
force-pushed
the
feature/search_shard_count_soft_limit
branch
from
b7e270c to
d7179ca
Compare
|
Thanks @jimferenczi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the new
action.search.shard_count.limitsetting whichconfigures the maximum number of shards that can be queried in a single search
request. It has a default value of 1000.