-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up InternalEngine#resolveDocVersion(...) method #122374
Merged
martijnvg
merged 10 commits into
elastic:main
from
martijnvg:InternalEngine_resolveDocVersion_method
Feb 14, 2025
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a04181a
Speed up InternalEngine#resolveDocVersion(...) method
martijnvg d3af272
Merge remote-tracking branch 'es/main' into InternalEngine_resolveDoc…
martijnvg ce44c20
Merge remote-tracking branch 'es/main' into InternalEngine_resolveDoc…
martijnvg 8072907
introduce Engine#acquireDirectoryReaderSupplier(...)
martijnvg b81fa73
assert that we have a reference
martijnvg 247c240
Merge remote-tracking branch 'es/main' into InternalEngine_resolveDoc…
martijnvg 552ad61
Merge remote-tracking branch 'es/main' into InternalEngine_resolveDoc…
martijnvg 1ee2699
iter
martijnvg 9daa2dd
Merge remote-tracking branch 'es/main' into InternalEngine_resolveDoc…
martijnvg 5c4028d
Merge remote-tracking branch 'es/main' into InternalEngine_resolveDoc…
martijnvg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only extended once, we can make this one class for the reader supplier can't we? Or better yet, maybe just inline the logic to save some cycles? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed: 1ee2699