Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up exchanges in EsqlNodeFailureIT #121633

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 4, 2025

If the query hits the failing index first, we will cancel the request, preventing exchange-sink requests and data-node requests from reaching another data node. As a result, exchange sinks could stay for 30 seconds.

@dnhatn dnhatn force-pushed the fix-field-loading-tests branch from 602daee to 41588d4 Compare February 4, 2025 16:20
@dnhatn dnhatn added v9.0.1 v8.19.0 v8.18.1 :Analytics/ES|QL AKA ESQL >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Feb 4, 2025
@dnhatn dnhatn marked this pull request as ready for review February 4, 2025 16:33
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine merged commit 9b6af6a into elastic:main Feb 4, 2025
17 checks passed
@dnhatn dnhatn deleted the fix-field-loading-tests branch February 4, 2025 17:32
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 4, 2025
If the query hits the failing index first, we will cancel the request,
preventing exchange-sink requests and data-node requests from reaching
another data node. As a result, exchange sinks could stay for 30
seconds.
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 4, 2025
If the query hits the failing index first, we will cancel the request,
preventing exchange-sink requests and data-node requests from reaching
another data node. As a result, exchange sinks could stay for 30
seconds.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.18
8.x
9.0

dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 4, 2025
If the query hits the failing index first, we will cancel the request,
preventing exchange-sink requests and data-node requests from reaching
another data node. As a result, exchange sinks could stay for 30
seconds.
fzowl pushed a commit to voyage-ai/elasticsearch that referenced this pull request Feb 4, 2025
If the query hits the failing index first, we will cancel the request,
preventing exchange-sink requests and data-node requests from reaching
another data node. As a result, exchange sinks could stay for 30
seconds.
elasticsearchmachine pushed a commit that referenced this pull request Feb 4, 2025
If the query hits the failing index first, we will cancel the request,
preventing exchange-sink requests and data-node requests from reaching
another data node. As a result, exchange sinks could stay for 30
seconds.
elasticsearchmachine pushed a commit that referenced this pull request Feb 4, 2025
If the query hits the failing index first, we will cancel the request,
preventing exchange-sink requests and data-node requests from reaching
another data node. As a result, exchange sinks could stay for 30
seconds.
elasticsearchmachine pushed a commit that referenced this pull request Feb 5, 2025
If the query hits the failing index first, we will cancel the request,
preventing exchange-sink requests and data-node requests from reaching
another data node. As a result, exchange sinks could stay for 30
seconds.
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 6, 2025
If the query hits the failing index first, we will cancel the request,
preventing exchange-sink requests and data-node requests from reaching
another data node. As a result, exchange sinks could stay for 30
seconds.
dnhatn added a commit that referenced this pull request Feb 6, 2025
If the query hits the failing index first, we will cancel the request,
preventing exchange-sink requests and data-node requests from reaching
another data node. As a result, exchange sinks could stay for 30
seconds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.1 v8.19.0 v9.0.1 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants