[8.x] ReindexDataStreamIndex bug in assertion caused by reference equality (#121325) #121596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#121325) Assertion was using reference equality on two boxed longs. So assertion could produce false positives. Change to Objects.equals to check value and avoid null check. (cherry picked from commit eeb745c)
parkertimmins
added
the
auto-merge-without-approval
dnhatn
added a commit
that referenced
this pull request
Feb 4, 2025
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 4, 2025
…121597) The thrown exception may be wrapped in an ExecutionException; therefore, we need to unwrap it before verification. Closes elastic#121596 Closes elastic#118193
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 4, 2025
…121597) The thrown exception may be wrapped in an ExecutionException; therefore, we need to unwrap it before verification. Closes elastic#121596 Closes elastic#118193
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 4, 2025
…121597) The thrown exception may be wrapped in an ExecutionException; therefore, we need to unwrap it before verification. Closes elastic#121596 Closes elastic#118193
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 4, 2025
…121597) The thrown exception may be wrapped in an ExecutionException; therefore, we need to unwrap it before verification. Closes elastic#121596 Closes elastic#118193
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
dnhatn
added a commit
that referenced
this pull request
Feb 4, 2025
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Feb 4, 2025
…121597) The thrown exception may be wrapped in an ExecutionException; therefore, we need to unwrap it before verification. Closes elastic#121596 Closes elastic#118193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation