-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Change function_named_parameters in Kibana doc to expected format #121585
[ES|QL] Change function_named_parameters in Kibana doc to expected format #121585
Conversation
Documentation preview: |
It looks like this PR modifies one or more |
@@ -30,7 +30,7 @@ | |||
} | |||
], | |||
"examples" : [ | |||
"FROM books \n| WHERE KQL(\"author: Faulkner\")\n| KEEP book_no, author \n| SORT book_no \n| LIMIT 5;" | |||
"FROM books \n| WHERE KQL(\"author: Faulkner\")\n| KEEP book_no, author \n| SORT book_no \n| LIMIT 5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recapture the kibana doc changes related to KQL
, QSTR
and MATCH
operator on main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Fang!
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Pinging @elastic/kibana-esql (ES|QL-ui) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:100
@@ -254,7 +254,7 @@ public Match( | |||
valueHint = { "none", "all" }, | |||
description = "Number of beginning characters left unchanged for fuzzy matching." | |||
) }, | |||
description = "Match additional options as <<esql-function-named-params,function named parameters>>." | |||
description = "(Optional) Match additional options as <<esql-function-named-params,function named parameters>>." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call adding this :+1
@@ -30,7 +30,7 @@ | |||
} | |||
], | |||
"examples" : [ | |||
"FROM books \n| WHERE KQL(\"author: Faulkner\")\n| KEEP book_no, author \n| SORT book_no \n| LIMIT 5;" | |||
"FROM books \n| WHERE KQL(\"author: Faulkner\")\n| KEEP book_no, author \n| SORT book_no \n| LIMIT 5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Fang!
…rmat (elastic#121585) * change function_named_parameters in kibana doc to expected format
…rmat (elastic#121585) * change function_named_parameters in kibana doc to expected format
…rmat (elastic#121585) * change function_named_parameters in kibana doc to expected format
Change the type of function named parameter from
function named parameters
to the expected format -function_named_parameters
the generated Kibana docs