Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Reenable heap attacks (#121565) #121575

Merged
merged 3 commits into from
Feb 4, 2025
Merged

ESQL: Reenable heap attacks (#121565) #121575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcf9deb
ESQL: Reenable heap attacks (#121565)
nik9000 Feb 3, 2025
582299b
Merge remote-tracking branch 'upstream/8.x' into 121465_8x
alex-spies Feb 4, 2025
a3c8436
Unmute
alex-spies Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,9 +545,6 @@ tests:
issue: https://github.com/elastic/elasticsearch/issues/121179
- class: org.elasticsearch.xpack.application.CohereServiceUpgradeIT
issue: https://github.com/elastic/elasticsearch/issues/121537
- class: org.elasticsearch.xpack.esql.heap_attack.HeapAttackIT
method: testLookupExplosionBigStringManyMatches
issue: https://github.com/elastic/elasticsearch/issues/121465
- class: org.elasticsearch.smoketest.DocsClientYamlTestSuiteIT
method: test {yaml=reference/snapshot-restore/apis/get-snapshot-api/line_488}
issue: https://github.com/elastic/elasticsearch/issues/121611
6 changes: 4 additions & 2 deletions ...p-attack/src/javaRestTest/java/org/elasticsearch/xpack/esql/heap_attack/HeapAttackIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,8 @@ public void testLookupExplosion() throws IOException {

public void testLookupExplosionManyMatches() throws IOException {
assertCircuitBreaks(() -> {
Map<?, ?> result = lookupExplosion(1500, 10000);
// 1500, 10000 is enough locally, but some CI machines need more.
Map<?, ?> result = lookupExplosion(2000, 10000);
logger.error("should have failed but got {}", result);
});
}
Expand Down Expand Up @@ -663,7 +664,8 @@ public void testLookupExplosionBigString() throws IOException {

public void testLookupExplosionBigStringManyMatches() throws IOException {
assertCircuitBreaks(() -> {
Map<?, ?> result = lookupExplosionBigString(500, 1);
// 500, 1 is enough to make it fail locally but some CI needs more
Map<?, ?> result = lookupExplosionBigString(800, 1);
logger.error("should have failed but got {}", result);
});
}
Expand Down