Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable New Semantic Text Format Only On Newly Created Indices #121556

Merged
merged 6 commits into from
Feb 3, 2025
Merged

Enable New Semantic Text Format Only On Newly Created Indices #121556

merged 6 commits into from
Feb 3, 2025

Conversation

Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Feb 3, 2025

Fixes a bug where the new semantic text format was retroactively enabled on existing indices in serverless

@Mikep86 Mikep86 added blocker :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v9.0.0 labels Feb 3, 2025
@Mikep86 Mikep86 requested review from jimczi and kderusso February 3, 2025 18:54
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@Mikep86 Mikep86 added the >bug label Feb 3, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @Mikep86, I've created a changelog YAML for you.

kderusso
kderusso reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but it sounds like we may need to re-work the approach.

kderusso
kderusso approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mikep86 Mikep86 added the auto-backport Automatically create backport pull requests when merged label Feb 3, 2025
@Mikep86 Mikep86 merged commit d23699f into elastic:main Feb 3, 2025
17 checks passed
@Mikep86 Mikep86 mentioned this pull request Feb 3, 2025
Merged
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Feb 3, 2025
@Mikep86
Enable New Semantic Text Format Only On Newly Created Indices (elasti…
a7e1cb4 
…c#121556)
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 9.0

Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Feb 3, 2025
@Mikep86
Enable New Semantic Text Format Only On Newly Created Indices (elasti…
973c29c 
…c#121556)

(cherry picked from commit d23699f)
@Mikep86 Mikep86 mentioned this pull request Feb 3, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Feb 3, 2025
@Mikep86
Enable New Semantic Text Format Only On Newly Created Indices (#121556)…
161ffa7 
… (#121571)
breskeby pushed a commit that referenced this pull request Feb 4, 2025
@Mikep86
Enable New Semantic Text Format Only On Newly Created Indices (#121556)…
93ca9ad 
… (#121574)

(cherry picked from commit d23699f)
fzowl pushed a commit to voyage-ai/elasticsearch that referenced this pull request Feb 4, 2025
@Mikep86 @fzowl
Enable New Semantic Text Format Only On Newly Created Indices (elasti…
e76b9a3 
…c#121556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kderusso kderusso kderusso approved these changes

@jimczi jimczi Awaiting requested review from jimczi

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged blocker >bug :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v9.0.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mikep86 @elasticsearchmachine @kderusso