Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test should replace /api/security/v1/saml with /api/security/saml/callback #99985

Closed
rodrigc opened this issue Sep 27, 2023 · 1 comment · Fixed by #98882
Closed

Unit test should replace /api/security/v1/saml with /api/security/saml/callback #99985

rodrigc opened this issue Sep 27, 2023 · 1 comment · Fixed by #98882
Labels
>enhancement :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team

Comments

@rodrigc
Copy link
Contributor

rodrigc commented Sep 27, 2023 •
edited
Loading

Description

In TransportSamlInitiateSingleSignOnActionTests.java, /api/security/v1/saml (deprecated) should be replaced with /api/security/saml/callback

In https://github.com/elastic/kibana/blob/b33effa182bcb7c9620c5435ab252d8067732655/x-pack/plugins/security/server/routes/authentication/saml.ts#L27

/api/security/saml/callback is the correct URL,
while /api/security/v1/saml is the deprecated URL.

Related to elastic/cloud-on-k8s#7118
@rodrigc rodrigc added >enhancement needs:triage Requires assignment of a team area label labels Sep 27, 2023
@rodrigc rodrigc mentioned this issue Sep 27, 2023
Merged
@gbanasiak gbanasiak added the :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) label Oct 4, 2023
@elasticsearchmachine elasticsearchmachine added Team:Security Meta label for security team and removed needs:triage Requires assignment of a team area label labels Oct 4, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

gwbrown pushed a commit that referenced this issue Oct 12, 2023
@rodrigc
Use non-deprecated Kibana SAML callback URL in tests (#98882)
c1c8d1e 
/api/security/saml/callback is the correct URL,
while /api/security/v1/saml is the deprecated URL.

See also: elastic/kibana#81733

Fixes: #99985

---------

Co-authored-by: Craig Rodrigues <[email protected]>
Signed-off-by: Athena Brown <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use non-deprecated Kibana SAML callback URL in tests
3 participants
@rodrigc @gbanasiak @elasticsearchmachine