Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Prefer secondary authentication headers when creating/updating transforms #86731

Closed
droberts195 opened this issue May 12, 2022 · 1 comment · Fixed by #86757
Closed

[ML] Prefer secondary authentication headers when creating/updating transforms #86731

droberts195 opened this issue May 12, 2022 · 1 comment · Fixed by #86757
Assignees
@benwtrent
Labels
>enhancement :ml/Transform Transform Team:ML Meta label for the ML team

Comments

@droberts195
Copy link
Contributor

This requirement is similar to #53801 but for transforms rather than ML jobs. The implementation can probably be similar to #54121.

If a transform is created or updated and a secondary authentication header is present then the security headers we persist should be based on that secondary authentication header.

If no secondary authentication header is present when a transform is created or updated then everything should work as it does today.

The reason for adding this functionality is to provide extra options when installing Fleet packages. We need to do a better job of setting the user that transforms embedded in solutions will run as, and being able to use different credentials to those of the user installing the Fleet package will be an important building block.
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label May 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@benwtrent benwtrent self-assigned this May 12, 2022
@benwtrent benwtrent mentioned this issue May 12, 2022
Merged
benwtrent added a commit that referenced this issue May 16, 2022
@benwtrent
[ML] [Transforms] prefer secondary auth headers for transforms (#86757)
b90b345 
When creating and updating transforms, it is possible for clients to provide secondary headers.

When PUT, _preview, _update is called with secondary authorization headers, those are then used or stored with the transform.

closes: #86731
@przemekwitek przemekwitek mentioned this issue Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benwtrent benwtrent

Labels
>enhancement :ml/Transform Transform Team:ML Meta label for the ML team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] [Transforms] prefer secondary auth headers for transforms benwtrent/elasticsearch
3 participants
@benwtrent @droberts195 @elasticmachine