Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow _doc as a type name #27750

Closed
jpountz opened this issue Dec 11, 2017 · 2 comments
Closed

Allow _doc as a type name #27750

jpountz opened this issue Dec 11, 2017 · 2 comments
Labels
blocker :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v6.2.0

Comments

@jpountz
Copy link
Contributor

jpountz commented Dec 11, 2017

As of 7.0, types support will be gone, the index API will be either PUT index/_doc/id or POST index/_doc and hits will use _doc as a fake type in the response. In order to allow users to have a smoother transition to 7.0, we should allow _doc as a type in 6.x.

Relates to #15613
@jpountz jpountz added :Search Foundations/Mapping Index mappings, including merging and defining field types blocker v6.2.0 labels Dec 11, 2017
@morphers82
Copy link

I have been naming my type the same as index, ie: PUT index_name/index_name/id
i don't think it should have to be anything specific or that will make many people's 6.0 indices not work with 7.0 if it has to be _doc.

@jpountz
Copy link
Contributor Author

jpountz commented Dec 12, 2017

@morphers82 To clarify, this is not a requirement, this is just a way to potentially make the transition easier for users who decide to opt in for the type name that will be used in 7.0. 6.x indices will work in 7.0 regardless of the type name.

The benefit of switching to _doc earlier is that index APIs will work the same way on 6.x and 7.x indices: PUT index/_doc/id or POST index/_doc.

@jpountz jpountz mentioned this issue Dec 12, 2017
Merged
jpountz added a commit to jpountz/elasticsearch that referenced this issue Dec 14, 2017
@jpountz
Allow _doc as a type.
3a7a138 
Allowing `_doc` as a type will enable users to make the transition to 7.0
smoother since the index APIs will be `PUT index/_doc/id` and `POST index/_doc`.
This also moves most of the documentation to `_doc` as a type name.

Closes elastic#27750
Closes elastic#27751
@jpountz jpountz mentioned this issue Dec 14, 2017
Merged
jpountz added a commit that referenced this issue Dec 14, 2017
@jpountz
Allow _doc as a type. (#27816)
1b66082 
Allowing `_doc` as a type will enable users to make the transition to 7.0
smoother since the index APIs will be `PUT index/_doc/id` and `POST index/_doc`.
This also moves most of the documentation to `_doc` as a type name.

Closes #27750
Closes #27751
jpountz added a commit that referenced this issue Dec 19, 2017
@jpountz
Allow _doc as a type. (#27816)
6113103 
Allowing `_doc` as a type will enable users to make the transition to 7.0
smoother since the index APIs will be `PUT index/_doc/id` and `POST index/_doc`.
This also moves most of the documentation to `_doc` as a type name.

Closes #27750
Closes #27751
@javanna javanna added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v6.2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpountz @javanna @morphers82