Fix compilation in CumulativeCardinalityAggregatorTests (#46000)

Some generics were specified at too fine-grained a level.
elastic · Aug 26, 2019 · 8ff48d8 · 8ff48d8
1 parent 54ccdc7
commit 8ff48d8
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/...csearch/xpack/datascience/cumulativecardinality/CumulativeCardinalityAggregatorTests.java b/...csearch/xpack/datascience/cumulativecardinality/CumulativeCardinalityAggregatorTests.java
@@ -116,12 +116,12 @@ public void testAllNull() throws IOException {
     }
 
     public void testParentValidations() throws IOException {
-        ValuesSourceConfig<ValuesSource.Numeric> numericVS = new ValuesSourceConfig<>(ValuesSourceType.NUMERIC);
+        ValuesSourceConfig<ValuesSource> valuesSource = new ValuesSourceConfig<>(ValuesSourceType.NUMERIC);
 
         // Histogram
         Set<PipelineAggregationBuilder> aggBuilders = new HashSet<>();
         aggBuilders.add(new CumulativeCardinalityPipelineAggregationBuilder("cumulative_card", "sum"));
-        AggregatorFactory parent = new HistogramAggregatorFactory("name", numericVS, 0.0d, 0.0d,
+        AggregatorFactory parent = new HistogramAggregatorFactory("name", valuesSource, 0.0d, 0.0d,
             mock(InternalOrder.class), false, 0L, 0.0d, 1.0d, mock(SearchContext.class), null,
             new AggregatorFactories.Builder(), Collections.emptyMap());
         CumulativeCardinalityPipelineAggregationBuilder builder
@@ -131,14 +131,15 @@ public void testParentValidations() throws IOException {
         // Date Histogram
         aggBuilders.clear();
         aggBuilders.add(new CumulativeCardinalityPipelineAggregationBuilder("cumulative_card", "sum"));
-        parent = new DateHistogramAggregatorFactory("name", numericVS, 0L,
+        parent = new DateHistogramAggregatorFactory("name", valuesSource, 0L,
             mock(InternalOrder.class), false, 0L, mock(Rounding.class), mock(Rounding.class),
             mock(ExtendedBounds.class), mock(SearchContext.class), mock(AggregatorFactory.class),
             new AggregatorFactories.Builder(), Collections.emptyMap());
         builder = new CumulativeCardinalityPipelineAggregationBuilder("name", "valid");
         builder.validate(parent, Collections.emptySet(), aggBuilders);
 
         // Auto Date Histogram
+        ValuesSourceConfig<ValuesSource.Numeric> numericVS = new ValuesSourceConfig<>(ValuesSourceType.NUMERIC);
         aggBuilders.clear();
         aggBuilders.add(new CumulativeCardinalityPipelineAggregationBuilder("cumulative_card", "sum"));
         AutoDateHistogramAggregationBuilder.RoundingInfo[] roundings = new AutoDateHistogramAggregationBuilder.RoundingInfo[1];
@@ -229,15 +230,16 @@ private static long asLong(String dateTime) {
 
     private static AggregatorFactory getRandomSequentiallyOrderedParentAgg() throws IOException {
         AggregatorFactory factory;
+        ValuesSourceConfig<ValuesSource> valuesSource = new ValuesSourceConfig<>(ValuesSourceType.NUMERIC);
         ValuesSourceConfig<ValuesSource.Numeric> numericVS = new ValuesSourceConfig<>(ValuesSourceType.NUMERIC);
         switch (randomIntBetween(0, 2)) {
             case 0:
-                factory = new HistogramAggregatorFactory("name", numericVS, 0.0d, 0.0d,
+                factory = new HistogramAggregatorFactory("name", valuesSource, 0.0d, 0.0d,
                     mock(InternalOrder.class), false, 0L, 0.0d, 1.0d, mock(SearchContext.class), null,
                     new AggregatorFactories.Builder(), Collections.emptyMap());
                 break;
             case 1:
-                factory = new DateHistogramAggregatorFactory("name", numericVS, 0L,
+                factory = new DateHistogramAggregatorFactory("name", valuesSource, 0L,
                     mock(InternalOrder.class), false, 0L, mock(Rounding.class), mock(Rounding.class),
                     mock(ExtendedBounds.class), mock(SearchContext.class), mock(AggregatorFactory.class),
                     new AggregatorFactories.Builder(), Collections.emptyMap());