TEST: Fix InternalEngine#testAcquireIndexCommit

The acquireIndexCommit was separated into acquireSafeIndexCommit and acquireLastIndexCommit, however the test was not updated accordingly. Relates #28271
elastic · Feb 17, 2018 · 4b47b99 · 4b47b99
1 parent 4541bd9
commit 4b47b99
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java b/server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java
@@ -4367,8 +4367,7 @@ public void testAcquireIndexCommit() throws Exception {
             for (int i = 0; i < numDocs; i++) {
                 index(engine, i);
             }
-            final boolean inSync = randomBoolean();
-            if (inSync) {
+            if (randomBoolean()) {
                 globalCheckpoint.set(numDocs - 1);
             }
             final boolean flushFirst = randomBoolean();
@@ -4387,7 +4386,7 @@ public void testAcquireIndexCommit() throws Exception {
             engine.flush();
             // check that we can still read the commit that we captured
             try (IndexReader reader = DirectoryReader.open(snapshot.getIndexCommit())) {
-                assertThat(reader.numDocs(), equalTo(flushFirst && (safeCommit == false || inSync) ? numDocs : 0));
+                assertThat(reader.numDocs(), equalTo(flushFirst && safeCommit == false ? numDocs : 0));
             }
             assertThat(DirectoryReader.listCommits(engine.store.directory()), hasSize(2));
             snapshot.close();