Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider CommonCatQueryParameters to validate query parameters #3260

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Dec 6, 2024

The JSON rest-api-spec generally encodes those cat parameters, so this reduces the number of errors.

This reduces the number of validation errors from 329 to 213.

The JSON rest-api-spec generally encodes this parameters, so that
reduces the number of errors.
@pquentin pquentin requested a review from a team as a code owner December 6, 2024 11:07
Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tested locally validating various endponts

@pquentin pquentin merged commit d9bf86f into main Dec 6, 2024
9 checks passed
@pquentin pquentin deleted the validate-common-cat-query-parameters branch December 6, 2024 14:20
Copy link
Contributor

github-actions bot commented Dec 6, 2024

The backport to 8.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-3260-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d9bf86fe712f25f7ef5c0037eab484a22008c896
# Push it to GitHub
git push --set-upstream origin backport-3260-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16

Then, create a pull request where the base branch is 8.16 and the compare/head branch is backport-3260-to-8.16.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3260-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d9bf86fe712f25f7ef5c0037eab484a22008c896
# Push it to GitHub
git push --set-upstream origin backport-3260-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-3260-to-8.17.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3260-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d9bf86fe712f25f7ef5c0037eab484a22008c896
# Push it to GitHub
git push --set-upstream origin backport-3260-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3260-to-8.x.

pquentin added a commit that referenced this pull request Dec 6, 2024
The JSON rest-api-spec generally encodes this parameters, so that
reduces the number of validation errors.

(cherry picked from commit d9bf86f)
pquentin added a commit that referenced this pull request Dec 6, 2024
#3261)

The JSON rest-api-spec generally encodes this parameters, so that
reduces the number of validation errors.

(cherry picked from commit d9bf86f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants