Skip default headers from AIOHttpConnection #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
force-pushed
the
aiohttp-auto-accept-encoding
branch
from
3b2d8c6 to
7155544
Compare
sethmlarson
force-pushed
the
aiohttp-auto-accept-encoding
branch
from
7155544 to
c0edde7
Compare
This was referenced Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically
aiohttpaddsAccept: */*andAccept-Encoding: gzip, deflateto requests if you don't explicitly opt-out, so opt out of all the automatic headers and setup an E2E test case for all of our HTTP connection classes so we can catch when these automatically added headers slip in.Closes #1601