Expose Response on GetTaskResponse #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit exposes Response on GetTaskResponse. Response is the response object for the action performed by the Task, so will vary by action. For this reason, expose Response as an internal LazyDocument, with a method to retrieve a TResponse from the deserialized LazyDocument bytes. Closes #3963
codebrain
approved these changes
Jul 30, 2019
This commit updates the GetResponse<T>() impl on GetTaskResponse to use the RequestResponseDeserializer when deserializing the LazyDocument. This is exposed as an internal method only. Remove LazyDocument ctor overloads that are superfluous.
codebrain
approved these changes
Aug 7, 2019
Mpdreamz
approved these changes
Aug 7, 2019
russcam
added a commit
that referenced
this pull request
Aug 7, 2019
* Expose Response on GetTaskResponse This commit exposes Response on GetTaskResponse. Response is the response object for the action performed by the Task, so will vary by action. For this reason, expose Response as an internal LazyDocument, with a method to retrieve a TResponse from the deserialized LazyDocument bytes. * Deserialize response with RequestResponseSerializer This commit updates the GetResponse<T>() impl on GetTaskResponse to use the RequestResponseDeserializer when deserializing the LazyDocument. This is exposed as an internal method only. Remove LazyDocument ctor overloads that are superfluous. Closes #3963 (cherry picked from commit ba5b1b1)
|
ported to 7.x in cc5efc4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit exposes Response on GetTaskResponse. Response is the response object for the action performed by the Task, so will vary by action. For this reason, expose Response as an internal LazyDocument, with a method to retrieve a TResponse from the deserialized LazyDocument bytes.
Closes #3963