Add ignore_missing to the remove processor

src/Nest/Ingest/Processors/RemoveProcessor.cs

@@ -1,10 +1,6 @@
 using Newtonsoft.Json;
 using System;
-using System.Collections.Generic;
-using System.Linq;
 using System.Linq.Expressions;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace Nest
 {
@@ -14,25 +10,42 @@ public interface IRemoveProcessor : IProcessor
 	{
 		[JsonProperty("field")]
 		Field Field { get; set; }
+
+		/// <summary>
+		/// If <c>true</c> and <see cref="Field"/> does not exist or is null,
+		/// the processor quietly exits without modifying the document. Default is <c>false</c>
+		/// </summary>
+		[JsonProperty("ignore_missing")]
+		bool? IgnoreMissing { get; set; }
 	}
 
+	/// <inheritdoc cref="IRemoveProcessor" />
 	public class RemoveProcessor : ProcessorBase, IRemoveProcessor
 	{
 		protected override string Name => "remove";
+		/// <inheritdoc cref="IRemoveProcessor.Field" />
 		public Field Field { get; set; }
+		/// <inheritdoc cref="IRemoveProcessor.IgnoreMissing" />
+		public bool? IgnoreMissing { get; set; }
 	}
 
+	/// <inheritdoc cref="IRemoveProcessor" />
 	public class RemoveProcessorDescriptor<T>
 		: ProcessorDescriptorBase<RemoveProcessorDescriptor<T>, IRemoveProcessor>, IRemoveProcessor
 		where T : class
 	{
 		protected override string Name => "remove";
 
 		Field IRemoveProcessor.Field { get; set; }
+		bool? IRemoveProcessor.IgnoreMissing { get; set; }
 
+		/// <inheritdoc cref="IRemoveProcessor.Field" />
 		public RemoveProcessorDescriptor<T> Field(Field field) => Assign(a => a.Field = field);
 
-		public RemoveProcessorDescriptor<T> Field(Expression<Func<T, object>> objectPath) =>
-			Assign(a => a.Field = objectPath);
+		/// <inheritdoc cref="IRemoveProcessor.Field" />
+		public RemoveProcessorDescriptor<T> Field(Expression<Func<T, object>> objectPath) => Assign(a => a.Field = objectPath);
+
+		/// <inheritdoc cref="IRemoveProcessor.IgnoreMissing" />
+		public RemoveProcessorDescriptor<T> IgnoreMissing(bool? ignoreMissing = true) => Assign(a => a.IgnoreMissing = ignoreMissing);
 	}
 }

src/Tests/Tests.Configuration/tests.default.yaml

@@ -5,7 +5,7 @@
 # tracked by git).
 
 # mode either u (unit test), i (integration test) or m (mixed mode)
-mode: u
+mode: m
 # the elasticsearch version that should be started
 # Can be a snapshot version of sonatype or "latest" to get the latest snapshot of sonatype
 elasticsearch_version: 6.4.1

src/Tests/Tests.Core/Extensions/SerializationTesterAssertionExtensions.cs

@@ -1,12 +1,17 @@
-using FluentAssertions;
+using System;
 using Tests.Core.Serialization;
 
 namespace Tests.Core.Extensions
 {
 	public static class SerializationTesterAssertionExtensions
 	{
-		public static void ShouldBeValid(this SerializationResult result, string message = null) =>
-			result.Success.Should().BeTrue("{0}", message + result);
+		public static void ShouldBeValid(this SerializationResult result, string message = null)
+		{
+			if (result.Success) return;
+			throw new Exception($@"Expected serialization to succeed but failed.
+{(message ?? string.Empty) + result}
+");
+		}
 
 		public static T AssertRoundTrip<T>(this SerializationTester tester, T @object, string message = null, bool preserveNullInExpected = false)
 		{

src/Tests/Tests/Ingest/DeletePipeline/DeletePipelineApiTests.cs

@@ -4,11 +4,10 @@
 using Tests.Core.ManagedElasticsearch.Clusters;
 using Tests.Framework;
 using Tests.Framework.Integration;
-using Tests.Framework.ManagedElasticsearch.Clusters;
-using Xunit;
 
 namespace Tests.Ingest.DeletePipeline
 {
+	//integration test is part of PipelineCrudTests
 	public class DeletePipelineApiTests : ApiTestBase<ReadOnlyCluster, IDeletePipelineResponse, IDeletePipelineRequest, DeletePipelineDescriptor, DeletePipelineRequest>
 	{
 		public DeletePipelineApiTests(ReadOnlyCluster cluster, EndpointUsage usage) : base(cluster, usage) { }

src/Tests/Tests/Ingest/GetPipeline/GetPipelineApiTests.cs

@@ -9,6 +9,7 @@
 
 namespace Tests.Ingest.GetPipeline
 {
+	//integration test is part of PipelineCrudTests
 	public class GetPipelineApiTests : ApiTestBase<ReadOnlyCluster, IGetPipelineResponse, IGetPipelineRequest, GetPipelineDescriptor, GetPipelineRequest>
 	{
 		public GetPipelineApiTests(ReadOnlyCluster cluster, EndpointUsage usage) : base(cluster, usage) { }