-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Serialize GeoLocation with internal serializer (#3997)
This commit adds GeoLocation to types handled by the internal serializer so that a property on a document POCO of type GeoLocation is serialized by the internal serializer. It's not possible with the current test configuration to test this scenario, because IL rewriting happens after unit tests are run, so the Json.NET constructs used on Nest types are recognised by the JsonNetSerializer. Have added test that _would_ test behaviour, should tests be run after IL-merging in the future. Fixes #3981 (cherry picked from commit 623c724)
- Loading branch information
Showing
2 changed files
with
33 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
using System.Text; | ||
using Elastic.Xunit.XunitPlumbing; | ||
using FluentAssertions; | ||
using Nest; | ||
using Tests.Core.Client; | ||
|
||
namespace Tests.Reproduce | ||
{ | ||
public class GitHubIssue3981 | ||
{ | ||
// This test always passes because the JsonPropertyAttribute on | ||
// the GeoLocation type are recognized by the JsonNetSerializer when used in tests, because the | ||
// IL rewriting to internalize Json.NET in the client happens *after* tests are run. | ||
[U] | ||
public void JsonNetSerializerSerializesGeoLocation() | ||
{ | ||
var document = new Document | ||
{ | ||
Location = new GeoLocation(45, 45) | ||
}; | ||
|
||
var indexResponse = TestClient.InMemoryWithJsonNetSerializer.IndexDocument(document); | ||
Encoding.UTF8.GetString(indexResponse.ApiCall.RequestBodyInBytes).Should().Contain("\"lat\"").And.Contain("\"lon\""); | ||
} | ||
|
||
private class Document | ||
{ | ||
public GeoLocation Location { get; set; } | ||
} | ||
} | ||
} |