Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Fixed error in Using Our Own ID section #484

Merged
merged 1 commit into from
Apr 18, 2016

Conversation

AshishThakur
Copy link
Contributor

Changed "The response indicates that the indexing request has been successfully created" to "The response indicates that the indexing request has been successfully executed"

@polyfractal
Copy link
Contributor

I think the intention was actually to say "The response indicates that the document has been successfully created". Let's change it to that, since that's a stronger statement than just saying the indexing request was executed (which could be nebulous if the document was created or not).

@AshishThakur
Copy link
Contributor Author

@polyfractal: Thanks for the feedback, made changes as per feedback.

@polyfractal
Copy link
Contributor

Sorry for the delay! Been busy with other projects.

Could you make a tiny tweak? It should be document, not _document :)

@AshishThakur
Copy link
Contributor Author

Thanks for the feedback, sure will fix this

@AshishThakur
Copy link
Contributor Author

Fixed as per feedback :)

@polyfractal
Copy link
Contributor

Merging, thanks!

@polyfractal polyfractal merged commit bf21de0 into elastic:master Apr 18, 2016
@ashishcp
Copy link

ashishcp commented Oct 2, 2017

@AshishThakur @polyfractal Can you please explain "FakeID" scheme? - As mentioned in the last paragraph of the subsection of Indexing a Document

I know this pull request is quite old but if you know about the fakeId scheme then it would be really helpful if I know about 😄. I tried to google about it but no help 😢 😞 .

I've created an issue for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants