Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout-related unit tests failing when using Undici 6.20.0 #155

Closed
JoshMock opened this issue Oct 14, 2024 · 1 comment · Fixed by #154
Closed

Timeout-related unit tests failing when using Undici 6.20.0 #155

JoshMock opened this issue Oct 14, 2024 · 1 comment · Fixed by #154
Assignees
@JoshMock
Labels
bug Something isn't working

Comments

@JoshMock
Copy link
Member

🐛 Bug Report

Undici unit tests related to timeouts are failing when running against Undici 6.20.0, which released last week. This may be an early indicator that timeout-related errors are being mishandled by the Elasticsearch client in some edge cases.

See recent failed test runs for evidence.

To Reproduce

Force Undici upgrade, then run the unit tests:

npm i [email protected]
npm test

Expected behavior

Tests should pass.
@JoshMock JoshMock added the bug Something isn't working label Oct 14, 2024
@JoshMock JoshMock self-assigned this Oct 14, 2024
@JoshMock
Copy link
Member Author

Likely related to this change: nodejs/undici#3495

JoshMock added a commit that referenced this issue Oct 15, 2024
@JoshMock
Fix Undici timeouts in tests
4d9be4e 
Fixes #155
@JoshMock JoshMock mentioned this issue Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshMock JoshMock

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Adjust timeout on Undici tests elastic/elastic-transport-js
1 participant
@JoshMock