Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle base fields imported from nested ECS definitions in a more generic way #779

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Apr 4, 2022

More future-proof implementation of #777.

Previous implementations considers base and tracing the only groups that can
contain top-level fields. Implementation on this change checks field by field to see
if they contain base fields.

It also handles the case of having groups with both nested and top-level fields, something
that doesn't happen now, but just in case, to don't lose definitions if it happens at some
moment.

@jsoriano jsoriano requested a review from a team April 4, 2022 09:09
@jsoriano jsoriano self-assigned this Apr 4, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-04T09:09:35.694+0000

  • Duration: 31 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 627
Skipped 0
Total 627

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@jsoriano jsoriano merged commit 58aa8b3 into elastic:main Apr 4, 2022
@jsoriano jsoriano deleted the fix-nested-import-base-fields branch April 4, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants