Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gotestsum as test runner #740

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Use gotestsum as test runner #740

merged 1 commit into from
Mar 18, 2022

Conversation

jsoriano
Copy link
Member

@efd6 found that current approach of parsing the output of go test can be problematic in some cases, as when running parallel tests.

gotestsum wraps go test --json, that is much less error prone that parsing plain go test output. It supports different output formats, including junit. This is also the approach used in Beats.

Thanks @efd6 for raising the issue, and for trying gotestsum in #721.

@jsoriano jsoriano requested a review from a team March 18, 2022 12:52
@jsoriano jsoriano self-assigned this Mar 18, 2022
@jsoriano jsoriano mentioned this pull request Mar 18, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-18T12:52:56.032+0000

  • Duration: 18 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 582
Skipped 1
Total 583

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano jsoriano merged commit 8b71e69 into elastic:main Mar 18, 2022
@jsoriano jsoriano deleted the gotestsum branch March 18, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants